Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placement_set.py for entities. #29

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix placement_set.py for entities. #29

merged 2 commits into from
Jul 31, 2023

Conversation

drodarie
Copy link
Contributor

Add tests for positions when count is not None (for entities).
Add documentation.
Force cast to int to prevent json errors.

Fix #20
Fix #21

@drodarie drodarie requested a review from Helveg July 26, 2023 11:56
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #29 (ab18e98) into main (635703c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files          11       11           
  Lines        1378     1378           
=======================================
  Hits         1119     1119           
  Misses        259      259           
Files Changed Coverage Δ
bsb_hdf5/placement_set.py 86.00% <100.00%> (ø)

@Helveg Helveg merged commit b80e862 into main Jul 31, 2023
9 checks passed
@Helveg Helveg deleted the fix/entities branch July 31, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlacementSet._track_add does not handle numpy.int64 Re-evaluate PlacementSet.append_data usages
2 participants