Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sinusoidal generator and receptor_type attr #12

Merged
merged 16 commits into from
Oct 4, 2024
Merged

feat: add sinusoidal generator and receptor_type attr #12

merged 16 commits into from
Oct 4, 2024

Conversation

marialauradeg98
Copy link
Contributor

@marialauradeg98 marialauradeg98 commented Sep 17, 2024 •
edited by drodarie
Loading

What has been done

  • Added sinusoidal Poisson generator
  • Added receptor_type field for devices
  • Add GHA for PR comming from external repositories (like this one)
  • Fix GHA for internal PR and isort.

What remains to be done

  • Finish documentation
  • Add unittests

@marialauradeg98 marialauradeg98 changed the title add NEST sinusoidal poisson generator as device add sinusoidal generator and receptor_type attr Sep 18, 2024
@marialauradeg98 marialauradeg98 changed the title add sinusoidal generator and receptor_type attr feat: add sinusoidal generator and receptor_type attr Sep 18, 2024
@drodarie drodarie added the feat label Sep 18, 2024
drodarie
drodarie reviewed Sep 22, 2024
View reviewed changes
Copy link
Contributor

@drodarie drodarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I contributed to the PR, I would like someone else to review it.

Helveg
Helveg requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@Helveg Helveg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Really cool unit tests :) Couple of UX notes

.github/workflows/isort.yml Outdated Show resolved Hide resolved
bsb_nest/device.py Show resolved Hide resolved
bsb_nest/devices/sinusoidal_poisson_generator.py Outdated Show resolved Hide resolved
@drodarie drodarie merged commit 8e4908a into dbbs-lab:main Oct 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drodarie drodarie drodarie left review comments

@Helveg Helveg Helveg approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marialauradeg98 @drodarie @Helveg