Set vt_num as long int #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this new branch the user can set the vt_num parameter passing a long int (and long is also the type of the parameter in the connection definition). This is coherent with the nature of the parameter.
To overcome the type error bug, we use vt_num_is_long_ bool, a boolean to manage nest calls and guarantee proper types (as described in stdp_connection_cosexp.h.
Note that this version is tested for nest2.20.2, according to the last lines of cerebmodule.cpp, but the expedient should work for previous versions too. In ./do_tests_NOMPI.sh every test returns SUCCESS.