Adding mysql 5.7 and 8.0 keywords and functions for auto-completion #767
Conversation
|
@laoshaw Thanks for this pull request! We really appreciate this. I'm going to leave a few comments on this for some things that might need updating. |
| 'USING', 'VALUES', 'VARCHAR', 'VIEW', 'WHEN', 'WHERE', 'WITH', | ||
| 'JSON', 'ISNULL', 'GREATEST', 'LEAST', 'BLOB', 'BIT', 'OPAQUE', | ||
| 'DATETIME', 'BOOLEAN', 'ARRAY', 'OBJECT', 'STRING', 'DOUBLE', 'NULL', | ||
| 'ENUM', 'TEXT'] |
There was a problem hiding this comment.
Can we move ISNULL, GREATEST, and LEAST down to the function list?
| 'JSON_MERGE_PATCH', 'JSON_MERGE_PRESERVE', 'JSON_OBJECT', 'JSON_PRETTY', | ||
| 'JSON_QUOTE', 'JSON_REMOVE', 'JSON_REPLACE', 'JSON_SEARCH', 'JSON_SET', | ||
| 'JSON_STORAGE_SIZE', 'JSON_TYPE', 'JSON_UNQUOTE', 'JSON_VALID', | ||
| 'JSON_ARRAYAVG', 'JSON_OBJECTAVG', 'JSON_OVERLAPS', 'JSON_SCHEMA_VALID', |
There was a problem hiding this comment.
Did you mean JSON_ARRAYAGG and JSON_OBJECTAGG?
| 'JSON_STORAGE_SIZE', 'JSON_TYPE', 'JSON_UNQUOTE', 'JSON_VALID', | ||
| 'JSON_ARRAYAVG', 'JSON_OBJECTAVG', 'JSON_OVERLAPS', 'JSON_SCHEMA_VALID', | ||
| 'JSON_SCHEMA_VALIDATION_REPORT', 'JSON_STORAGE_FREE', 'JSON_TABLE', | ||
| 'MEMBER_OF'] |
There was a problem hiding this comment.
MEMBER_OF() looks like it should be two words (MEMBER OF()).
|
Also, do you think we could put the new suggestions in alphabetical order with the old ones? It definitely makes it easier for developers to find things in the list when we need to make changes, etc. |
|
yes I think the new one is better. |
I don't understand. Are you saying that you'll create a new PR or will you add more commits to this PR? |
Description
Added keywords and json functions from mysql 5.7 and 8.0 for auto-completion
Checklist
changelog.md. -- not seen this fileAUTHORSfile (or it's already there). -- change too small to be added