dbeaver/pro#5848 api for renaming projects #3600
Open
+454
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
previously approved these changes
Jul 24, 2025
devnaumov
previously approved these changes
Jul 28, 2025
Wroud
previously approved these changes
Aug 4, 2025
# Conflicts: # server/bundles/io.cloudbeaver.model/src/io/cloudbeaver/model/session/BaseWebSession.java
sergeyteleshev
previously approved these changes
Sep 16, 2025
Nexus6v2
previously approved these changes
Sep 16, 2025
yagudin10
dismissed stale reviews from sergeyteleshev and Nexus6v2
via
092dba1
yagudin10
force-pushed
the
5848-rename-projects
branch
from
092dba1 to
ced131a
Compare
Wroud
previously approved these changes
Sep 18, 2025
yagudin10
force-pushed
the
5848-rename-projects
branch
from
d1625aa to
1ded054
Compare
sergeyteleshev
approved these changes
Sep 24, 2025
Comment on lines
+160
to
+167
| this.projectInfoEventHandler.onEvent<IProjectInfoEvent>( | ||
| ServerEventId.CbRmProjectUpdated, | ||
| e => { | ||
| this.projectInfoResource.markOutdated(e.projectId); | ||
| }, | ||
| undefined, | ||
| this.projectInfoResource, | ||
| ); |
There was a problem hiding this comment.
it is a bit weird that we subscribe for events here in the service instead of directly in resource
I would rather move these 2 event handlers inside projectInfoResource
Wroud
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.