dbeaver/pro#5471 [CB] Add shortcuts to tooltips data editor toolbar #3750
+159
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have two buttons with different shortcuts for saving SQL as a script(first save) and saving already created script (updating). On UI they had the same icon and were more or less identical for the user. We decided to use the same shortcut and labels for both buttons (mod + S).
Wroud
requested changes
Sep 17, 2025
...ges/plugin-data-viewer/src/TableViewer/TableFooter/TableFooterMenu/TableFooterMenuService.ts
Outdated
Show resolved
Hide resolved
Wroud
previously approved these changes
Sep 22, 2025
Comment on lines
224
to
231
| tooltip: t('data_viewer_action_edit_add') + ' (' + getBindingLabel(KEY_BINDING_ADD) + ')', | ||
| }; | ||
| case ACTION_DUPLICATE: | ||
| return { ...action.info, label: '', icon: '/icons/data_add_copy_sm.svg', tooltip: t('data_viewer_action_edit_add_copy') + ' (' + getBindingLabel(KEY_BINDING_DUPLICATE) + ')' }; | ||
| return { | ||
| ...action.info, | ||
| label: '', | ||
| icon: '/icons/data_add_copy_sm.svg', | ||
| tooltip: t('data_viewer_action_edit_add_copy') + ' (' + getBindingLabel(KEY_BINDING_DUPLICATE) + ')', |
There was a problem hiding this comment.
Can we specify duplicate and add bindings in the same way as 'delete'?
There was a problem hiding this comment.
Yes, we can, do you want me to make it in this task or create another one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Save as script and save buttons now use the same shortcut since they never appear together and look similar so they function as a single button. (https://github.com/dbeaver/pro/issues/6891) Also fixes order.
