Skip to content

Add run-level discriminator to container names #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clkao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add run-level discriminator to container names #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ade_bench/handlers/trial_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,15 @@ def __init__(
task_key: str = "base",
variant_config: dict | None = None,
agent_name = None,
run_discriminator: str = "",
):
self.trial_name = trial_name
self.input_path = input_path
self.output_path = output_path
self.task_key = task_key
self.variant_config = variant_config or {}
self.agent_name = agent_name
self._run_discriminator = run_discriminator

self._logger = logger.getChild(__name__)
self.task = Task.from_yaml(self._task_config_path)
Expand Down Expand Up @@ -216,7 +218,10 @@ def docker_image_prefix(self) -> str:

@property
def client_container_name(self) -> str:
return f"{self.trial_name}__client".replace(".", "-")
base = self.trial_name.replace(".", "-")
if self._run_discriminator:
return f"{base}__{self._run_discriminator}__client"
return f"{base}__client"

@property
def client_image_name(self) -> str:
Expand Down
3 changes: 3 additions & 0 deletions ade_bench/harness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import asyncio
import hashlib
import logging
import shutil
import subprocess
Expand Down Expand Up @@ -1182,13 +1183,15 @@ def _execute_single_trial(
Returns:
TrialResults: The results of the trial execution
"""
run_discriminator = hashlib.sha256(self._run_id.encode()).hexdigest()[:6]
trial_handler = TrialHandler(
trial_name=trial_name,
input_path=task_path,
output_path=self._run_path,
task_key=task_key,
variant_config=config,
agent_name=self._agent_name,
run_discriminator=run_discriminator,
)

try:
Expand Down