Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of delete+insert incremental strategy #151

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+22 −27
Open

Improve performance of delete+insert incremental strategy #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
773e8d3
Fix incremental delete+insert SQL
ataft Apr 10, 2024
b8b8a7f
Merge branch 'main' into main
colin-rogers-dbt Aug 9, 2024
66facbc
Merge branch 'main' into main
colin-rogers-dbt Oct 16, 2024
5e89033
Merge branch 'main' into main
dbeatty10 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20240410-163601.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix incremental delete+insert SQL
time: 2024-04-10T16:36:43.253228-05:00
custom:
Author: ataft
Issue: "150"
43 changes: 16 additions & 27 deletions dbt/include/global_project/macros/materializations/models/incremental/merge.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,34 +61,23 @@
{%- set dest_cols_csv = get_quoted_csv(dest_columns | map(attribute="name")) -%}

{% if unique_key %}
{% if unique_key is sequence and unique_key is not string %}
delete from {{target }}
using {{ source }}
where (
{% for key in unique_key %}
{{ source }}.{{ key }} = {{ target }}.{{ key }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterallenwebb and I took a look at this PR today.

This line of code is updated by #110, so we think that PR should be reviewed/merged prior to reviewing this PR further.

{{ "and " if not loop.last}}
{% endfor %}
{% if incremental_predicates %}
{% for predicate in incremental_predicates %}
and {{ predicate }}
{% endfor %}
{% endif %}
);
{% else %}
delete from {{ target }}
where (
{{ unique_key }}) in (
select ({{ unique_key }})
from {{ source }}
)
{%- if incremental_predicates %}
{% for predicate in incremental_predicates %}
and {{ predicate }}
{% endfor %}
{%- endif -%};

{% if unique_key is string %}
{% set unique_key = [unique_key] %}
{% endif %}

{%- set unique_key_str = unique_key|join(', ') -%}

delete from {{ target }}
where ({{ unique_key_str }}) in (
select distinct {{ unique_key_str }}
from {{ source }}
)
{%- if incremental_predicates %}
{% for predicate in incremental_predicates %}
and {{ predicate }}
{% endfor %}
{%- endif -%};

{% endif %}

insert into {{ target }} ({{ dest_cols_csv }})
Expand Down