-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hard_deletes config and new_record Option for Snapshots #317
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
…tes="new_record" from a different mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, some of them maybe speaking to my ignorance when it comes to the snapshot materialization. Aside from that, will there be tests associated with this change? I would have expected some updates in dbt-tests-adapter
in this PR as well as a PR in something like dbt-postgres
that points to this branch.
dbt/include/global_project/macros/materializations/snapshots/helpers.sql
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/helpers.sql
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/helpers.sql
Outdated
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/helpers.sql
Show resolved
Hide resolved
dbt/include/global_project/macros/materializations/snapshots/snapshot.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests.
@colin-rogers-dbt I'm discussing the testing strategy with @mikealfare now. I'm adding tests in dbt-core, which is where most of the snapshot testing infrastructure already exists. I'm willing to try to get some of that infrastructure moved over into this repo, and I think that makes sense, but I'm worried that gating on that could jeopardize getting this into 1.9rc1, @graciegoheen. |
I have addressed the change request by adding a test!
@cla-bot check |
@peterallenwebb is a member of dbt Labs, hence has signed the CLA. Merging without this branch check running by manual confirmation. |
resolves dbt-labs/dbt-core#10235
The corresponding dbt-core PR adds the new configuration values: dbt-labs/dbt-core#10972
Checklist