InProgress: Add tags to SavedQueries #10987
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
theyostalservice
force-pushed
the
patricky__add_tags_to_saved_query
branch
3 times, most recently
from
150228b
to
f0eaad0
Compare
This was referenced Nov 13, 2024
theyostalservice
force-pushed
the
patricky__add_tags_to_saved_query
branch
from
f0eaad0
to
2d39824
Compare
Comment on lines
819
to
829
| config_tags = config.get("tags") | ||
| unparsed_tags = unparsed.tags | ||
| tags: Union[List[str], str] | ||
| if config_tags: | ||
| if isinstance(config_tags, str): | ||
| config_tags = [config_tags] | ||
| if isinstance(unparsed_tags, str): | ||
| unparsed_tags = [unparsed_tags] | ||
| tags = list(set([*unparsed_tags, *config_tags])) | ||
| else: | ||
| tags = unparsed_tags |
There was a problem hiding this comment.
TODO: there's got to be a slightly cleaner way to write this.
theyostalservice
added a commit
to dbt-labs/dbt-semantic-interfaces
that referenced
this pull request
Nov 14, 2024
Resolves [#369](#369) ### Description Addresses internal Linear issue SL-2896. Users currently can execute parts of their DAG conditionally based on tags added to individual nodes (see [documentation](https://docs.getdbt.com/reference/resource-configs/tags)). This brings SavedQueries in line with other similar nodes and allows the use of tags as described in that documentation. (See the added tests for examples.) It does not add any hierarchical behaviors for these tags. A related [PR #10987](dbt-labs/dbt-core#10987) is in progress in dbt-core. ### Checklist - [x] I have read [the contributing guide](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md) and understand what's expected of me - [x] I have signed the [CLA](https://docs.getdbt.com/docs/contributor-license-agreements) - [x] This PR includes tests, or tests are not required/relevant for this PR - [x] I have run `changie new` to [create a changelog entry](https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/CONTRIBUTING.md#adding-a-changelog-entry)
theyostalservice
force-pushed
the
patricky__add_tags_to_saved_query
branch
from
2d39824
to
56d3899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Solution
Checklist