Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access DEBUG flag through get_flags() #11069

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Threynaud
Copy link

Resolves #11068

Problem

ManifestLoader.check_for_spaces_in_resource_names() causes an AttributeError in certain cases, for instance when used with SQLFluff dbt templater.
AttributeError: 'DbtConfigArgs' object has no attribute 'DEBUG'

Solution

Access the DEBUG flag through the get_flags()method as done everywhere else in the codebase.

Checklist

  • [ x] I have read the contributing guide and understand what's expected of me.
  • [ x] I have run this code in development, and it appears to resolve the stated issue.
  • [x ] This PR includes tests, or tests are not required or relevant for this PR.
  • [ x] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • [ x] This PR includes type annotations for new and modified functions.

@Threynaud Threynaud requested a review from a team as a code owner November 28, 2024 15:22
Copy link

cla-bot bot commented Nov 28, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Thomas Reynaud.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Nov 28, 2024
Copy link

cla-bot bot commented Nov 28, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Thomas Reynaud.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Nov 28, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Thomas Reynaud.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Threynaud Threynaud changed the title Access DEBUG flag though get_flags() Access DEBUG flag through get_flags() Nov 28, 2024
@MichelleArk MichelleArk self-requested a review November 28, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from a community member
Projects
None yet
1 participant