Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.5.latest] Support quoted parameter list for MultiOption cli options #8695

Closed
wants to merge 2 commits into from

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 22, 2023

Backport 417fc2a from #8665.

* allow multioption to be quoted

* changelog

* fix test

* remove list format

* fix tests

* fix list object

* review arg change

* fix quotes

* Update .changes/unreleased/Features-20230918-150855.yaml

* add types

* convert list to set in test

* make mypy happy

* mroe mypy happiness

* more mypy happiness

* last mypy change

* add node to test
@cla-bot cla-bot bot added the cla:yes label Sep 22, 2023
@emmyoop emmyoop marked this pull request as draft September 22, 2023 19:50
@emmyoop emmyoop closed this Sep 25, 2023
@emmyoop emmyoop reopened this Sep 25, 2023
@emmyoop
Copy link
Member Author

emmyoop commented Sep 25, 2023

This is in a weird state because I opened it against main. CLosing in favor of #8703

@emmyoop emmyoop closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant