Fix model validation, add CI #16
Conversation
* make column_properties/required an arrary * escape regex * fix cli for installing ajv-cli * escape regexes in the other files, get them passing validation * add node_modules to gitignore * update npm cli to not write package.json & lock file * ci job testing against real files * remove cache key from jobs, not using package.json * job is using fixture files as a test, not running dbt init
| @@ -131,7 +131,7 @@ | |||
| "oneOf": [ | |||
| { | |||
| "type": "string", | |||
| "pattern": "{{.*}}" | |||
| "pattern": "\\{\\{.*\\}\\}" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
This is awesome @kochalex! Thanks for doing this.
I'm happy with schema version 7 if that's the default - I skipped on picking a version because I wasn't sure what the right one was, and it seemed to work without specifying one 😬 if you want to add that to these files as well I'd be happy to include it in this PR?
Otherwise, just two pedantic changes around capitalisation (or lack thereof) of dbt.
Such a good idea to put some CI on this, json is fiddly at the best of times.
Not yet, but over time as they get more robust it's not out of the question! We're also thinking about listing on schemastore, but that has some tradeoffs (see #3) |
|
Ok, I've made the changes (caps and adding in |
|
@kochalex we squash and merge so it's all good! Thank you for doing this 🌟 |
When trying to use these schemas in a CI workflow with our DBT project, I ran into a few errors with the JSON schema documents with both Ajv and jsonschema.
This has a couple of fixes that allowed the schemas themselves to be validated as draft 7. (I used draft 7 since it's the most common from my experience, but it might also be good to add a
$schemaentry to the files). There's also a sample GitHub Actions CI workflow that tests using ajv-cli:dbt_project.ymlandmodel.ymlfiles generated withdbt init.Here's a run on my fork: https://github.com/kochalex/dbt-jsonschema/actions/runs/3048375813
Separately, are there any plans for DBT to publish these schemas in a registry like https://schemas.getdbt.com/ or have them officially part of DBT?
I've pointed my VS Code at these updated files and our project's YAML files validate ok, but it should be noted that the existing files also seemed to work ok with the VS Code YAML extension, it was just the CI cases that failed (with two separate validators). I know CI is not the intended use case here. 😸