Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 1.8.latest] Pin build dependencies to final releases #939

Merged

Conversation

mikealfare
Copy link
Contributor

resolves #930

Problem

We never pinned build dependencies to final releases when creating the minor branch.

Solution

Pin dbt-common, dbt-adapters, and dbt-core to final releases to avoid getting pre-releases (e.g. 1.9.0b1).

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Oct 23, 2024
@cla-bot cla-bot bot added the cla:yes label Oct 23, 2024
@mikealfare mikealfare merged commit a030df7 into 1.8.latest Oct 23, 2024
39 checks passed
@mikealfare mikealfare deleted the hotfix/1.8.latest/pin-dbt-core-to-final-release branch October 23, 2024 16:49
@mikealfare mikealfare linked an issue Oct 23, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Pinning to dbt-redshift~=1.8 installs dbt-core 1.9.0-b2
2 participants