Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TimeDimension parameter ordering #156

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix TimeDimension parameter ordering #156

merged 1 commit into from
Sep 26, 2023

Conversation

DevonFulcher
Copy link
Contributor

Description

This PR fixes the ordering of the TimeDimension parameters so that entity_path is in the same position as it has been, right after time_granularity_name. This will prevent errors if a user attempts to use positional parameters to pass in entity_path, especially in the Jinja sandbox.

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 26, 2023
QMalcolm
QMalcolm approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, looks good to me!

@DevonFulcher DevonFulcher merged commit 19d589e into main Sep 26, 2023
12 checks passed
@DevonFulcher DevonFulcher deleted the fix_time_dimension branch September 26, 2023 14:52
@DevonFulcher DevonFulcher mentioned this pull request Sep 29, 2023
Merged
4 tasks
DevonFulcher added a commit that referenced this pull request Oct 3, 2023
@DevonFulcher
Query interface updates to add Dimension(...).grain(...) support (#162)
ac3ae95 
Due to MetricFlow's reliance on version 0.2.x of DSI, the updates to support Dimension(...).grain(...) need to be made to this branch as well. I just combined the work from these PRs into this one #156, #154, #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm approved these changes

@tlento tlento Awaiting requested review from tlento

@courtneyholcomb courtneyholcomb Awaiting requested review from courtneyholcomb

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevonFulcher @QMalcolm