Skip to content

Bump dev version - #297

Merged
courtneyholcomb merged 2 commits into
mainfrom
court/bump-again
Jun 19, 2024
Merged

courtneyholcomb merged 2 commits into
mainfrom
court/bump-again

Conversation

@courtneyholcomb

Copy link
Copy Markdown
Contributor

Description

Needed to get some new fields into MF (specifically cumulative_type_params).

Comment thread pyproject.toml Outdated
[project]
name = "dbt-semantic-interfaces"
version = "0.6.0"
version = "0.6.1dev0"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.6.1.dev0

@tlento tlento Jun 18, 2024 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, should this be 0.6.1.dev0 or should it be 0.7.0.dev0? We're on new feature kind of stuff, right? Whichever works, though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should bump to 0.7.0 unless it's a breaking change. If we do, it will require another round of bumping version requirements in core which should not be necessary for non-breaking changes.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the DSI and MF docs differ on the naming practices so that's why it feels like there's thrash here. https://www.notion.so/dbtlabs/Metricflow-Build-Release-Process-81023685d93a45da8211b05dc36b7bf8?pvs=4#9accf24d2929404ba7b9337ad21a33e3

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to suit PEP!

@courtneyholcomb
courtneyholcomb requested a review from tlento June 18, 2024 23:58
@courtneyholcomb
courtneyholcomb merged commit 34b80b4 into main Jun 19, 2024
@courtneyholcomb
courtneyholcomb deleted the court/bump-again branch June 19, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants