Don't require time_granularity_name in QueryInterfaceTimeDimensionFactory
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
WilliamDee
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #306
Description
Currently, the protocol for
QueryInterfaceTimeDimensionFactoryrequirestime_granularity_nameto be set. This is inconsistent with other interfaces, where granularity is not required and can be resolved at query time. For example, the DSI implementation of this protocol (WhereFilterTimeDimensionFactory) does not require the parameter, but the implementation in MFS does.I did not include tests since this is a change to the protocol only. The corresponding change in MFS will have tests.
Checklist
changie newto create a changelog entry