Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test serializability of SerializableDataclass subclasses #315

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Jul 16, 2024

Description

Since there are no tests that verify the serializability of SerializableDataclass subclasses, this PR adds a mechanism for enumerating them and a test for them.

Checklist

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@plypaul plypaul marked this pull request as ready for review July 16, 2024 21:06
@plypaul plypaul requested review from QMalcolm, graciegoheen and a team as code owners July 16, 2024 21:06
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Curious if you will add something similar to MF / MFS?

@plypaul
Copy link
Contributor Author

plypaul commented Jul 17, 2024

Curious if you will add something similar to MF / MFS?

Yes, I'm planning to add similar tests for those projects.

@plypaul plypaul merged commit d1bf57a into main Jul 17, 2024
74 of 76 checks passed
@plypaul plypaul deleted the plypaul--64--serializable-dataclass-updates branch July 17, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants