Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for order-by and limit in saved queries #323

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Add support for order-by and limit in saved queries #323

merged 3 commits into from
Aug 5, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Aug 5, 2024 •
edited
Loading

Description

This PR updates the saved-query protocol / implementation to support saved queries. Validations are added in subsequent PRs.

Checklist

@cla-bot cla-bot bot added the cla:yes label Aug 5, 2024
@plypaul plypaul changed the title P sq order by limit 01 Add support for order-by and limit in saved queries Aug 5, 2024
@plypaul plypaul marked this pull request as ready for review August 5, 2024 18:53
@plypaul plypaul requested review from QMalcolm, graciegoheen and a team as code owners August 5, 2024 18:53
@plypaul plypaul merged commit fb3717c into main Aug 5, 2024
88 checks passed
@plypaul plypaul deleted the p--sq-order-by-limit--01 branch August 5, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamDee WilliamDee WilliamDee approved these changes

@QMalcolm QMalcolm Awaiting requested review from QMalcolm QMalcolm is a code owner

@graciegoheen graciegoheen Awaiting requested review from graciegoheen graciegoheen is a code owner

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plypaul @WilliamDee