Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a macro that is entirely a docstring #1185

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Remove a macro that is entirely a docstring #1185

merged 2 commits into from
Sep 19, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Sep 19, 2024 •
edited
Loading

Problem

We have a macro in our code that is entirely a docstring. It is not called anywhere within dbt-snowflake. It also contains a link to a resource that is no longer relevant.

Solution

Remove the macro.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Sep 19, 2024
@mikealfare mikealfare self-assigned this Sep 19, 2024
@mikealfare mikealfare requested a review from a team as a code owner September 19, 2024 00:22
@cla-bot cla-bot bot added the cla:yes label Sep 19, 2024
@mikealfare mikealfare changed the title Remove a link which is no longer relevant Remove a macro that is entirely a docstring Sep 19, 2024
amychen1776
amychen1776 approved these changes Sep 19, 2024
View reviewed changes
Copy link

@amychen1776 amychen1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪 it

VersusFacit
VersusFacit approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope we don't end up needing this in the tragicomedy that is our universe 😂

@mikealfare mikealfare merged commit 084674f into main Sep 19, 2024
15 checks passed
@mikealfare mikealfare deleted the remove-broken-link branch September 19, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

@amychen1776 amychen1776 amychen1776 approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikealfare @amychen1776 @VersusFacit