Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adap 321/add iceberg incremental models #1194

Merged
merged 6 commits into from
Sep 27, 2024
Merged

Adap 321/add iceberg incremental models #1194

merged 6 commits into from
Sep 27, 2024

Conversation

VersusFacit
Copy link
Contributor

Problem

Iceberg metadata issues caused there to be 3 affected rows instead of 2 as needed on the append test's show command.

Solution

3 -> 2

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Sep 26, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner September 26, 2024 23:47
@cla-bot cla-bot bot added the cla:yes label Sep 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@VersusFacit VersusFacit added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Sep 26, 2024
@VersusFacit VersusFacit force-pushed the ADAP-321/add_iceberg_incremental_models branch from e8e99ec to 2a6b5c8 Compare September 26, 2024 23:48
@cla-bot cla-bot bot added the cla:yes label Sep 26, 2024
@VersusFacit VersusFacit force-pushed the ADAP-321/add_iceberg_incremental_models branch from da5efc7 to 78c49bc Compare September 27, 2024 00:21
@VersusFacit VersusFacit force-pushed the ADAP-321/add_iceberg_incremental_models branch from 338c583 to 02bf9ed Compare September 27, 2024 00:46
@VersusFacit VersusFacit merged commit 423111f into main Sep 27, 2024
19 checks passed
@VersusFacit VersusFacit deleted the ADAP-321/add_iceberg_incremental_models branch September 27, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VersusFacit @colin-rogers-dbt