Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snowflake telemetry. #1209

Merged
merged 12 commits into from
Oct 28, 2024
Merged

Add snowflake telemetry. #1209

merged 12 commits into from
Oct 28, 2024

Conversation

VersusFacit
Copy link
Contributor

Related to dbt-labs/dbt-adapters#301

Problem

We need a snowflake override to get the data for snowflake.

Solution

Override the base class method.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit self-assigned this Oct 16, 2024
@VersusFacit VersusFacit requested a review from a team as a code owner October 16, 2024 10:56
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
@VersusFacit
Copy link
Contributor Author

VersusFacit commented Oct 18, 2024

image

Note my base adapter was 1.7.X so we have the overrides right!

And it's the core tracking function that is using the Snowflake override :D

My local env for testing.

image

Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one question, is it worth adding a test to this since we are tracking an additional dbt-snowflake-specific attribute?

dbt/adapters/snowflake/impl.py Show resolved Hide resolved
@VersusFacit
Copy link
Contributor Author

I suppose it's worth adding a unit test (done) because this gives us extra security with base adapter / core calls that could be tripped up through many layers of indirection.

@VersusFacit VersusFacit merged commit df643a0 into main Oct 28, 2024
41 checks passed
@VersusFacit VersusFacit deleted the ADAP-301/add-adapter-telemetry branch October 28, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants