Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adap 209/update iceberg docs note #1253

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Conversation

VersusFacit
Copy link
Contributor

resolves https://github.com/dbt-labs/adapters-team-private/issues/210

Problem

We added the docs flag to a Jinja macro where there was a placeholder but we'd like to add it to the main flag object as well.

Solution

Add the docs url to the flag itself.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit requested a review from a team as a code owner November 19, 2024 06:59
@VersusFacit VersusFacit self-assigned this Nov 19, 2024
@cla-bot cla-bot bot added the cla:yes label Nov 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@VersusFacit
Copy link
Contributor Author

image

Proof of the warning with the link 👍

@VersusFacit VersusFacit merged commit dca565b into main Nov 19, 2024
37 checks passed
@VersusFacit VersusFacit deleted the ADAP-209/update_iceberg_docs_note branch November 19, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants