Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dbt-common and dbt-adapters package #885

Merged
merged 76 commits into from
Jan 18, 2024

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Jan 12, 2024

resolves #890
docs dbt-labs/docs.getdbt.com/#

Problem

dbt-core is updating name spacing for dbt-common this pr is to have a base of work to test and merge into feature branch once they are ready.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Jan 12, 2024
@cla-bot cla-bot bot added the cla:yes label Jan 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 marked this pull request as ready for review January 16, 2024 20:19
@McKnight-42 McKnight-42 requested a review from a team as a code owner January 16, 2024 20:19
@McKnight-42 McKnight-42 changed the title prepare draft pr for dbt-common name change in core update for dbt-common ref to repo instead of dir in core Jan 16, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit on the way something was already done.

table = dbt.common.clients.agate_helper.empty_table()
table = dbt_common.clients.agate_helper.empty_table()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to not use the same pattern as other imports instead, ie

from dbt_common.clients.agate_helper import empty_table

and then this line is

table = empty_table()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was actually looking at that myself earlier, going to double check that we aren't using something else called agate_helpper to prevent a name collision, that's really the only other use case I've seen it done this way via exceptions.

Base automatically changed from feature/decouple-adapters-from-core to main January 17, 2024 17:05
@McKnight-42 McKnight-42 changed the title update for dbt-common ref to repo instead of dir in core Migrate to dbt-common and dbt-adapters package Jan 17, 2024
@martynydbt
Copy link

Thank you @emmyoop and @colin-rogers-dbt for approving! Nice progress!

@colin-rogers-dbt colin-rogers-dbt merged commit 4b2d938 into main Jan 18, 2024
14 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the feature/update-dbt-common-name branch January 18, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-1097] Migrate to dbt-common and dbt-adapters package
4 participants