-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to dbt-common and dbt-adapters package #885
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit on the way something was already done.
table = dbt.common.clients.agate_helper.empty_table() | ||
table = dbt_common.clients.agate_helper.empty_table() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to not use the same pattern as other imports instead, ie
from dbt_common.clients.agate_helper import empty_table
and then this line is
table = empty_table()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was actually looking at that myself earlier, going to double check that we aren't using something else called agate_helpper to prevent a name collision, that's really the only other use case I've seen it done this way via exceptions.
Thank you @emmyoop and @colin-rogers-dbt for approving! Nice progress! |
resolves #890
docs dbt-labs/docs.getdbt.com/#
Problem
dbt-core is updating name spacing for dbt-common this pr is to have a base of work to test and merge into feature branch once they are ready.
Solution
Checklist