This repository was archived by the owner on Sep 2, 2025. It is now read-only.
[ADAP-548] Make cluster key sorting optional on table creation#917
Closed
Slanman3755 wants to merge 3 commits intodbt-labs:mainfrom
Closed
[ADAP-548] Make cluster key sorting optional on table creation#917Slanman3755 wants to merge 3 commits intodbt-labs:mainfrom
Slanman3755 wants to merge 3 commits intodbt-labs:mainfrom
Conversation
Author
|
I copied a generic test for this new feature. I may need help making it more practical. There should probably also be a unit test for this change but I did not see any unit tests already in place for the cluster_by config field that I could easily add to. |
Author
|
Still waiting on feedback for this change. |
Contributor
|
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days. |
Contributor
|
Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-adapters#735
docs dbt-labs/docs.getdbt.com/#
Problem
Creating a table with a cluster key always adds an order by to the create table statement. This is usually not necessary and should be optional.
Solution
Add a new optional config flag for table creation (order_by_cluster_key) that can enable or disable the addition of the order by statement when a cluster key is present.
Checklist