Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source freshness #6744

Open
wants to merge 7 commits into
base: current
Choose a base branch
from
Open

Source freshness #6744

wants to merge 7 commits into from

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Jan 9, 2025

What are you changing in this pull request and why?

I have created this PR following this Git issue #4408 raised by Colin T to update the docs to clarify deferral content.

Initially there was a discussion on creating a guide but since the docs already have some info on source freshness, I opted to update the About dbt source command doc and Add sources to your DAG doc.

Closes: #4408

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner January 9, 2025 13:10
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 14, 2025 10:57am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jan 9, 2025
website/docs/reference/commands/source.md Outdated Show resolved Hide resolved
website/docs/docs/build/sources.md Outdated Show resolved Hide resolved
website/docs/docs/build/sources.md Outdated Show resolved Hide resolved
website/docs/docs/build/sources.md Show resolved Hide resolved
@mirnawong1
Copy link
Contributor

mirnawong1 commented Jan 13, 2025

hey @nataliefiann , here's a checklist of things i recommend you check out and summarize my first pass in reviewing:

  • best to create and use snippets if you want to use content in more than one page.
  • for docs links — use relative paths, not absolute
  • i might be misunderstanding but don’t really get what the ‘Build models based on source freshness’ section is trying to communicate? is it trying to tell us about how source freshness works? yr about tests? the header mentions its about building models based on source freshness but i dont really understand how a user would do that based on this info?
  • sugg your pr has a tech review first before a docs review so you can finalize any technical content before it reaches docs team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify deferral content
2 participants