Skip to content

Source freshness#6744

Merged
nataliefiann merged 25 commits intocurrentfrom
nfiann-sourcefreshness
Mar 12, 2025
Merged

Source freshness#6744
nataliefiann merged 25 commits intocurrentfrom
nfiann-sourcefreshness

Conversation

@nataliefiann
Copy link
Copy Markdown
Contributor

@nataliefiann nataliefiann commented Jan 9, 2025

What are you changing in this pull request and why?

I have created this PR following this Git issue #4408 raised by Colin T to update the docs to clarify deferral content.

Initially there was a discussion on creating a guide but since the docs already have some info on source freshness, I opted to update the About dbt source command doc and Add sources to your DAG doc.

Closes: #4408

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@nataliefiann nataliefiann requested a review from a team as a code owner January 9, 2025 13:10
@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Mar 12, 2025 8:13pm

@github-actions github-actions Bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jan 9, 2025
Comment thread website/docs/reference/commands/source.md Outdated
@@ -0,0 +1 @@
<Lightbox src="/img/docs/dbt-cloud/select-source-freshness.png" title="Selecting source freshness"/> No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure why we're using an image as a snippet here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unresolving this to double check why we're using an image as snippet if it's not used anywhere?

Copy link
Copy Markdown
Contributor Author

@nataliefiann nataliefiann Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

I've removed the snippet file and the modeltest file from the PR

Kind Regards
Natalie

Comment thread website/docs/reference/commands/source.md Outdated
Comment thread website/docs/docs/build/sources.md Outdated
Comment thread website/docs/docs/build/sources.md Outdated
Comment thread website/docs/docs/build/sources.md
@mirnawong1
Copy link
Copy Markdown
Contributor

mirnawong1 commented Jan 13, 2025

hey @nataliefiann , here's a checklist of things i recommend you check out and summarize my first pass in reviewing:

  • best to create and use snippets if you want to use content in more than one page.
  • for docs links — use relative paths, not absolute
  • i might be misunderstanding but don’t really get what the ‘Build models based on source freshness’ section is trying to communicate? is it trying to tell us about how source freshness works? yr about tests? the header mentions its about building models based on source freshness but i dont really understand how a user would do that based on this info?
  • sugg your pr has a tech review first before a docs review so you can finalize any technical content before it reaches docs team

nataliefiann and others added 2 commits January 13, 2025 11:39
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@github-actions github-actions Bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Feb 19, 2025
@colin-thornburg
Copy link
Copy Markdown
Contributor

@nataliefiann - can we add in these 2 benefits

By using the commands in that order, it ensures models are updated based on the latest data. This also eliminates wasted compute cycles on data that has not changed or updated and only builds models when necessary.

nataliefiann and others added 2 commits March 12, 2025 15:33
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Comment thread website/docs/reference/commands/source.md Outdated
Comment thread website/docs/reference/commands/source.md Outdated
Comment thread website/docs/reference/commands/source.md Outdated
Comment thread website/docs/reference/commands/source.md Outdated
Comment thread website/docs/docs/build/sources.md Outdated
Comment thread website/docs/reference/commands/source.md Outdated
nataliefiann and others added 2 commits March 12, 2025 20:04
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
Co-authored-by: Mirna Wong <89008547+mirnawong1@users.noreply.github.com>
@nataliefiann nataliefiann merged commit 96b1609 into current Mar 12, 2025
@nataliefiann nataliefiann deleted the nfiann-sourcefreshness branch March 12, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Improvements or additions to content size: medium This change will take up to a week to address

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify deferral content

3 participants