Use helper function to find matching instances in dataset #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
commented
Nov 20, 2024
| time_dimension_spec: TimeDimensionSpec, | ||
| ) -> ColumnAssociation: | ||
| """Given the name of the time dimension, return the set of columns associated with it in the data set.""" | ||
| def instances_for_time_dimensions( |
There was a problem hiding this comment.
The pluralized version of this is not currently used but will be used further up the stack.
plypaul
approved these changes
Nov 21, 2024
metricflow/dataset/sql_dataset.py
Outdated
| return column_associations_to_return[0] | ||
| def instance_for_time_dimension(self, time_dimension_spec: TimeDimensionSpec) -> TimeDimensionInstance: | ||
| """Given the name of the time dimension, return the instance associated with it in the data set.""" | ||
| return self.instances_for_time_dimensions((time_dimension_spec,))[0] |
There was a problem hiding this comment.
A check / error message for the number of instances returned by instances_for_time_dimensions would be helpful here.
plypaul
pushed a commit
that referenced
this pull request
Feb 6, 2025
Clean up. Just reducing some repeated code in dataflow to SQL logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up. Just reducing some repeated code in dataflow to SQL logic.