Bug fix: apply time constraints after time offsets #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/simp4.5
branch
from
a4cc534 to
dfbb7a7
Compare
courtneyholcomb
changed the title
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
plypaul
reviewed
Nov 21, 2024
| if metric_spec.has_time_offset: | ||
| queried_agg_time_dimension_specs = queried_linkable_specs.included_agg_time_dimension_specs_for_metric( | ||
| metric_reference=metric_spec.reference, metric_lookup=self._metric_lookup | ||
| ) | ||
| output_node = JoinToTimeSpineNode.create( | ||
| parent_node=output_node, | ||
| requested_agg_time_dimension_specs=queried_agg_time_dimension_specs, | ||
| time_range_constraint=predicate_pushdown_state.time_range_constraint, |
There was a problem hiding this comment.
Without the filter, is the join producing a lot more rows?
There was a problem hiding this comment.
It might be! But with it, the results might be inaccurate.
plypaul
approved these changes
Nov 27, 2024
courtneyholcomb
force-pushed
the
court/simp4
branch
from
0781ab3 to
b966ccc
Compare
Time constraints were being applied before time offsets in some scenarios. This is incorrect because the values will change during the offset. This fixes that. Customers likely never saw this bug because time constraints are only available to open source users, and this may never have been released to them.
courtneyholcomb
force-pushed
the
court/simp4.5
branch
from
bcc895d to
3ca4fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time constraints were being applied before time offsets in some scenarios. This is incorrect because the values will change during the offset. This fixes that. Customers likely never saw this bug because time constraints are only available to open source users, and this may never have been released to them.