Various cleanup #1545
Merged
Various cleanup #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/simp6
branch
from
f39948c to
2fa5459
Compare
courtneyholcomb
force-pushed
the
court/simp6
branch
from
2fa5459 to
9633e66
Compare
plypaul
approved these changes
Dec 4, 2024
courtneyholcomb
force-pushed
the
court/simp-5
branch
from
9754025 to
dee0a9d
Compare
These tests aren't testing anything particularly useful, and they will require significant refactoring to work with changes up the stack. Remove them instead.
This will change later when we support multiple time spine nodes per query. For now, move the error to the core function so that we don't need to do error handling everywhere this gets used (which will be several places further up the stack). Also adds a helper to improve readability.
courtneyholcomb
force-pushed
the
court/simp6
branch
from
2390fca to
2ca267f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some random cleanup of issues I found in the process of building this stack.