Add support for querying with metric alias #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serramatutu
force-pushed
the
serramatutu/metric-alias
branch
2 times, most recently
from
42b8dcf to
0fbefff
Compare
serramatutu
added
the
Run Tests With Other SQL Engines
serramatutu
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
serramatutu
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
serramatutu
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
serramatutu
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
metricflow-semantics/metricflow_semantics/query/query_resolver.py
Outdated
Show resolved
Hide resolved
metricflow-semantics/metricflow_semantics/query/query_resolver.py
Outdated
Show resolved
Hide resolved
courtneyholcomb
force-pushed
the
serramatutu/metric-alias
branch
3 times, most recently
from
12a2463 to
06eada3
Compare
plypaul
reviewed
Dec 20, 2024
There was a problem hiding this comment.
- Since the alias in this case is describing user inputs, can it be added as a field to
ResolverInputForMetric? - If not, need to have a think about the placement as the spec pattern is more about identifying items in the semantic manifest.
- Can you add a test case for when the user specifies two aliases that are the same in a query?
...w/snapshots/test_engine_specific_rendering.py/SqlPlan/BigQuery/test_add_time_expr__plan0.sql
Outdated
Show resolved
Hide resolved
courtneyholcomb
force-pushed
the
serramatutu/metric-alias
branch
from
86a7499 to
76b1c03
Compare
WilliamDee
force-pushed
the
serramatutu/metric-alias
branch
from
75d0e42 to
ea952ef
Compare
WilliamDee
force-pushed
the
serramatutu/metric-alias
branch
from
ea952ef to
dfc4743
Compare
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces support for querying with aliased metrics. This is done by adding an
AliasSpecsNodeafter the order by step inDataflowPlanBuilder. To make the alias information reach that point, I also had to modify some of the query interface classes to allow aliases in metrics.You can review commit by commit.