Add window_function attribute to TimeDimensionSpec
#1576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/custom-offset1
branch
2 times, most recently
from
73fb43b to
255f78d
Compare
courtneyholcomb
force-pushed
the
court/custom-offset2
branch
from
68c9435 to
3710873
Compare
courtneyholcomb
force-pushed
the
court/custom-offset1
branch
from
255f78d to
4390e63
Compare
courtneyholcomb
force-pushed
the
court/custom-offset2
branch
from
3710873 to
d54bc63
Compare
courtneyholcomb
force-pushed
the
court/custom-offset1
branch
from
4390e63 to
e193228
Compare
courtneyholcomb
force-pushed
the
court/custom-offset2
branch
from
d54bc63 to
ca93230
Compare
WilliamDee
approved these changes
Dec 19, 2024
courtneyholcomb
force-pushed
the
court/custom-offset1
branch
from
618fd1e to
d46303f
Compare
… in FilterElementsNode This will more accurately match the column name since it includes more information about the spec
This will allow us to track which specs have had a window function applied between DataflowPlan nodes
courtneyholcomb
force-pushed
the
court/custom-offset2
branch
from
ca93230 to
1b71261
Compare
plypaul
pushed a commit
that referenced
this pull request
Feb 6, 2025
And related cleanup. This will allow us to track which specs have had a window function applied between DataflowPlan nodes, which is needed for the dataflow plan used for custom offset windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And related cleanup. This will allow us to track which specs have had a window function applied between DataflowPlan nodes, which is needed for the dataflow plan used for custom offset windows.