Allow tabulate versions >= 0.8.9 #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Tabulate is an optional dependency of Pandas, which we use for printing our query results. This means we must depend on tabulate directly otherwise users see unhelpful errors about installing the tabulate dependency. Our version was pinned to ~0.8.9, but this comes with unexpected limitations for users interacting with other packages in the broader dbt ecosystem which require 0.9 or later, so here we are.
tlento
force-pushed
the
update-tabulate-version
branch
from
b3d28ba to
5c839cc
Compare
WilliamDee
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabulate is an optional dependency of Pandas, which we use for printing
our query results. This means we must depend on tabulate directly
otherwise users see unhelpful errors about installing the tabulate
dependency.
Our version was pinned to ~0.8.9, but this comes with unexpected
limitations for users interacting with other packages in the broader
dbt ecosystem which require 0.9 or later, so here we are.
Resolves #397