Methods to look up agg_time_dimensions
#995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
commented
Jan 25, 2024
| linkable_element_sets_to_merge.append( | ||
| ValidLinkableSpecResolver._get_elements_in_semantic_model(semantic_model) | ||
| ) | ||
| linkable_element_sets_to_merge.append(self._get_elements_in_semantic_model(semantic_model)) |
There was a problem hiding this comment.
Changes in this file were made to avoid a circular import.
courtneyholcomb
changed the title
agg_time_dimensions
courtneyholcomb
requested review from
tlento,
plypaul and
WilliamDee
and removed request for
tlento and
plypaul
tlento
approved these changes
Jan 25, 2024
| linkable_element_sets_to_merge.append( | ||
| ValidLinkableSpecResolver._get_elements_in_semantic_model(semantic_model) | ||
| ) | ||
| linkable_element_sets_to_merge.append(self._get_elements_in_semantic_model(semantic_model)) |
| @@ -300,14 +301,12 @@ def _resolved_primary_entity(semantic_model: SemanticModel) -> Optional[EntityRe | |||
| ) | |||
|
|
|||
| # This should be caught by the validation, but adding a sanity check. | |||
| assert len(entities_with_type_primary) <= 1, f"Found >1 primary entity in {semantic_model}" | |||
| assert len(entities_with_type_primary) <= 1, f"Found > 1 primary entity in {semantic_model}" | |||
| entity_link = self.resolved_primary_entity(semantic_model) | ||
| assert ( | ||
| entity_link is not None | ||
| ), f"Expected semantic model {semantic_model} to have a primary entity since is contains dimensions, but found none." |
There was a problem hiding this comment.
Ok, this is implicit, right? We know it contains a measure, which means it must have an agg_time_dimension, which means it has at least a time dimension.
Maybe update the message to to have a primary entity since it has a measure requiring an agg_time_dimension?
Regardless, micro-nit - it not is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some methods that will be used to enable querying with
agg_time_dimensioninstead ofmetric_time.MetricLookup.get_valid_agg_time_dimensions_for_metric()will be used in validations, whileSemanticModelLookup.get_agg_time_dimension_specs_for_measure()will be used in query building.