Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved default XML serialization location #143

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Improved default XML serialization location #143

merged 2 commits into from
Aug 30, 2024

Conversation

dcarbone
Copy link
Owner

@dcarbone dcarbone commented Aug 30, 2024 •
edited
Loading

This PR does the following

  • When adding new value containing and primitive types to collection fields, only the first will be allowed to be serialized to an XML attribute
  • Updating the default $xmlLocation value of value container types to element

@dcarbone dcarbone self-assigned this Aug 30, 2024
@dcarbone dcarbone added this to the v3.2.0 milestone Aug 30, 2024
@dcarbone dcarbone mentioned this pull request Aug 30, 2024
Closed
@dcarbone dcarbone linked an issue Aug 30, 2024 that may be closed by this pull request
XML Attributes instead of Elements #126
Closed
@dcarbone dcarbone merged commit 6680ff4 into main Aug 30, 2024
17 of 20 checks passed
@dcarbone dcarbone deleted the dcarbone/xml-loc-improvement branch August 30, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dcarbone dcarbone

Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

XML Attributes instead of Elements
1 participant
@dcarbone