render referenced components #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean Mertz <[email protected]>
parasyte
reviewed
May 7, 2024
Comment on lines
-153
to
-154
| component_references: parse_component_references(chars)?, | ||
| affordances: parse_affordances(chars)?, |
There was a problem hiding this comment.
Are parse_component_references and parse_affordances dead code now? I don't see any other references to them.
There was a problem hiding this comment.
Good catch! Removed them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced components weren't rendered correctly, regardless of their nesting level. This resolves that issue.
With this implementation, the affordances of components are embedded in the places from which they are referenced as-is. We can expand upon this to make them visually distinct, and/or make them collapseable (and possibly collapse them by default).
closes #3