Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about deprecated mem::uninitialized() #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linkmauve
Copy link

The API to use for this is now mem::MaybeUninit().

The API to use for this is now mem::MaybeUninit().
@linkmauve
Copy link
Author

You still have Rust 1.13 in the CI, this one is four years old at this point, is this something you want to keep or should I upgrade it to a more sensible baseline? MaybeUninit exists since Rust 1.36, which could be a sensible new baseline.

@dcuddeback
Copy link
Owner

Hi @linkmauve. This is something I want to do at some point. Supporting four year-old compilers is a feature. I'll just need to make a judgement call of when it's okay to bump the minimum supported version to 1.36. It's likely I could do that soon with a version bump after I have time to sit down and think about it. I'm dealing with a family emergency right now, so I'm just not in the frame of mind to think about it for a while.

@Noratrieb
Copy link

Hi @dcuddeback. 1.36 is about three years old now, and I think you should be able to merge this now from this point of view. No serious Rust project is compiling on 1.36 now, since almost every other crate has a higher MSRV. If you still don't have time for personal reasons, that's fine, but I just wanted to remind you :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants