Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix&feat: set positions of dialogs and filters dynamically #131

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tbor00
Copy link
Member

@tbor00 tbor00 commented Jul 15, 2023

Summary

This PR includes:

  • set position dynamically with useTooltip hook
  • close the dialog when click outside of the component
  • useTooltip was refactorized to improve reactivity and visibility
  • add hook tu detect the SSR and use useEffect instead of useLayoutEffect
  • modified tests to pass all and cover new changes
  • add stories to ConfirmDialog component

How did you test this change?

  • Mannualy with storybook 🎨
  • All tests was passed ✅

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 715a4c9:

Sandbox Source
Vanilla Configuration
React Configuration

@tbor00 tbor00 changed the title Fix/dialog position fix&feat: set positions of dialogs and filters dynamically Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant