Skip to content

Conversation

@weirdo12
Copy link
Contributor

Added $EXTERNALSYM code for C++Builder compatibility. For example:

OSVERSIONINFOEXA = _OSVERSIONINFOEXA;
{$EXTERNALSYM OSVERSIONINFOEXA}

Without this, C++Builder sees OSVERSIONINFOEXA as a redefinition of OSVERSIONINFOEXA in winnt.h.

Added $EXTERNALSYM code for C++Builder compatibility. For example:

OSVERSIONINFOEXA = _OSVERSIONINFOEXA;
{$EXTERNALSYM OSVERSIONINFOEXA}

Without this, C++Builder sees OSVERSIONINFOEXA as a redefinition of OSVERSIONINFOEXA in winnt.h.
@delphidabbler
Copy link
Member

Hi @weirdo12

Sorry to take so long to reply. I've been taking a break from coding and have just noticed your issue & PR.

I'm quite busy just now but will try to review it next week.

BTW you're just in time. My plan is to update the code to detect Win 11 25H2 and re the end of Win 10 support and then archive this project. I'll roll your update into that final release.

@weirdo12
Copy link
Contributor Author

weirdo12 commented Nov 5, 2025

Perfect!

@delphidabbler
Copy link
Member

Once again, apologies for the delay. I've just not been able to find a minute lately.

Anyhow, I'm happy with this pull request and am merging it into the develop branch. It'll be in the next release.

As for testing, I've checked that the revised code compiles in Delphi XE and 13, but am trusting you that C++ Builder is happy! (I never use it and don't have it installed!)

Thanks very much for contributing this.

@delphidabbler delphidabbler merged commit e8de58b into ddablib:develop Nov 29, 2025
@delphidabbler
Copy link
Member

@weirdo12 Released as part of v5.33.0

@weirdo12
Copy link
Contributor Author

weirdo12 commented Nov 29, 2025

That's cool. Peter, thank you for including the code and including me in that acknowledgments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants