Save to localstorage #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddongule
reviewed
Aug 30, 2022
Comment on lines
+55
to
+73
| const handleReset = () => { | ||
| setName(''); | ||
| setIsModalOpen(false); | ||
|
|
||
| // localstoage | ||
| localStorage.setItem('mainInput', JSON.stringify(MAIN)); | ||
| localStorage.setItem('subInput', JSON.stringify(SUB)); | ||
|
|
||
| // input values | ||
| setMainInput(MAIN); | ||
| setSubInput(SUB); | ||
| for (var i = 0; i < 9; i++) { | ||
| for (var j = 0; j < 9; j++) { | ||
| setInputValue(i + 1, j, ''); | ||
| } | ||
| setInputValue('main', i, ''); | ||
| } | ||
| alert('초기화 되었습니다.'); | ||
| }; |
There was a problem hiding this comment.
I think this is already great, but what do you think about putting one more hurdle before initialization? 🤩
Just in case that button is pressed against by people's intension.
things like..
const handleReset = () => {
if (window.confirm('초기화 하시겠습니까?') {
setName('')
...
alert('초기화 되었습니다.')
}
}
Comment on lines
-50
to
+55
| /> | ||
| ></span> |
There was a problem hiding this comment.
I think self-closing tag could be better because there is nothing between them! 😁
how do you think of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People can save and revise their goals easily. Utilized localStorage.
Screen.Recording.2022-08-28.at.5.00.31.PM.mov