Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
📜 Recent review details🔇 Additional comments (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds Fedora 44 build variants to the Packer configuration by introducing two new local version variables and two Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@fedora.pkr.hcl`:
- Around line 95-96: The iso_url and iso_checksum entries are still referencing
the wrong path and variable (they use the "Everything" directory and
local.silverblue43_version), so update iso_url and iso_checksum to point to the
correct Silverblue 44 location and version variable; replace "Everything" with
the proper Fedora Silverblue ISO path and change references from
local.silverblue43_version to the Silverblue 44 variable (e.g.,
local.silverblue44_version) so iso_url and iso_checksum resolve the correct
Fedora-Silverblue-44 ISO and CHECKSUM artifacts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2cfc7d15-8963-42c3-a9e4-de9100e8f2bd
📒 Files selected for processing (1)
fedora.pkr.hcl
📜 Review details
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: ci / box (alpine321) / test alpine321
- GitHub Check: ci / box (ubuntu2510) / build ubuntu2510
- GitHub Check: ci / box (opensuseleap156) / build opensuseleap156
- GitHub Check: ci / box (opensusetumbleweed) / build opensusetumbleweed
- GitHub Check: ci / box (fedora42) / build fedora42
- GitHub Check: ci / box (silverblue42) / build silverblue42
- GitHub Check: ci / box (opensuseleap16) / build opensuseleap16
- GitHub Check: ci / box (ubuntu2404) / build ubuntu2404
- GitHub Check: ci / box (silverblue43) / build silverblue43
- GitHub Check: ci / box (fedora43) / build fedora43
🔇 Additional comments (2)
fedora.pkr.hcl (2)
10-13: Fedora 44 beta local/version wiring looks consistent.The added renovate metadata and
fedora44_version/silverblue44_versionlocals are coherent with the existing pattern.
82-90:fedora44source block is correctly configured.
iso_url,iso_checksum, and kickstart template usage follow the expected pattern for Fedora Everything builds.
There was a problem hiding this comment.
♻️ Duplicate comments (1)
fedora.pkr.hcl (1)
92-100:⚠️ Potential issue | 🔴 CriticalFix Silverblue 44 ISO and checksum paths:
/Everything/should be/Silverblue/.Lines 95-96 use
/Everything/in the paths, but Silverblue ISOs are served from/Silverblue/. The actual mirror contains these files at the correct location and the proposed fix matches them exactly.🔧 Proposed fix
source "qemu.fedora" { name = "silverblue44" output_directory = "output-${source.name}" - iso_url = "https://dl.fedoraproject.org/pub/fedora/linux/releases/test/44_Beta/Everything/x86_64/iso/Fedora-Silverblue-ostree-x86_64-${local.silverblue44_version}.iso" - iso_checksum = "file:https://dl.fedoraproject.org/pub/fedora/linux/releases/test/44_Beta/Everything/x86_64/iso/Fedora-Silverblue-iso-${local.silverblue44_version}-x86_64-CHECKSUM" + iso_url = "https://dl.fedoraproject.org/pub/fedora/linux/releases/test/44_Beta/Silverblue/x86_64/iso/Fedora-Silverblue-ostree-x86_64-${local.silverblue44_version}.iso" + iso_checksum = "file:https://dl.fedoraproject.org/pub/fedora/linux/releases/test/44_Beta/Silverblue/x86_64/iso/Fedora-Silverblue-iso-${local.silverblue44_version}-x86_64-CHECKSUM" http_content = { "/fedora.ks" = templatefile("${path.root}/fedora-silverblue.ks", { path = path, hostname = source.name, version = "44" }) } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@fedora.pkr.hcl` around lines 92 - 100, The ISO URL and checksum paths in the qemu.fedora source block (source "qemu.fedora", referencing local.silverblue44_version) use the wrong directory segment "/Everything/"; update the iso_url and iso_checksum values to use "/Silverblue/" instead so both iso_url and iso_checksum point to the Silverblue directory on the Fedora mirror (leave the templatefile/http_content unchanged).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@fedora.pkr.hcl`:
- Around line 92-100: The ISO URL and checksum paths in the qemu.fedora source
block (source "qemu.fedora", referencing local.silverblue44_version) use the
wrong directory segment "/Everything/"; update the iso_url and iso_checksum
values to use "/Silverblue/" instead so both iso_url and iso_checksum point to
the Silverblue directory on the Fedora mirror (leave the
templatefile/http_content unchanged).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8605a8d4-c3f2-4957-8856-e5d719c814a1
📒 Files selected for processing (1)
fedora.pkr.hcl
📜 Review details
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: ci / box (opensusetumbleweed) / test opensusetumbleweed
- GitHub Check: ci / box (debian13) / test debian13
- GitHub Check: ci / box (nixos) / test nixos
- GitHub Check: ci / box (archlinux) / test archlinux
- GitHub Check: ci / box (fedora44) / build fedora44
- GitHub Check: ci / box (silverblue43) / build silverblue43
- GitHub Check: ci / box (ubuntu2510) / build ubuntu2510
- GitHub Check: ci / box (fedora43) / build fedora43
- GitHub Check: ci / box (ubuntu2404) / build ubuntu2404
- GitHub Check: ci / box (opensuseleap156) / build opensuseleap156
- GitHub Check: ci / box (fedora42) / build fedora42
- GitHub Check: ci / box (opensuseleap16) / build opensuseleap16
- GitHub Check: ci / box (silverblue42) / build silverblue42
🔇 Additional comments (2)
fedora.pkr.hcl (2)
10-13: LGTM!The local variables and renovate comments are correctly configured for the Fedora 44 Beta release, with appropriate version format and registry URLs.
82-90: No changes required—the checksum filename is correct for Fedora 44 Beta.Verification confirms the checksum filename
Fedora-Everything-iso-${local.fedora44_version}-x86_64-CHECKSUMis the actual pattern used by Fedora's mirror for the 44 Beta release. The-isosegment, which differs from stable releases, is not a typo but the correct filename format for this release branch.> Likely an incorrect or invalid review comment.
amezin
force-pushed
the
f44
branch
2 times, most recently
from
7485def to
b7f4e90
Compare
1 participant
No description provided.