ContainerMakerInterface, making kind() method final on manifests

src/Core/ConfigMap/AbstractConfigMap.php

@@ -16,7 +16,7 @@ public function binaryData(StringMap $binaryData): void
     {
     }
 
-    public static function kind(): string
+    final public static function kind(): string
     {
         return ConfigMap::KIND;
     }

src/Core/Container/ContainerMaker.php

@@ -15,10 +15,10 @@
 use Dealroadshow\K8S\Framework\Core\Container\VolumeMount\VolumeMountsConfigurator;
 use Dealroadshow\K8S\Framework\Middleware\ContainerImageMiddlewareInterface;
 
-class ContainerMaker
+class ContainerMaker implements ContainerMakerInterface
 {
     /**
-     * @var ContainerImageMiddlewareInterface[]|iterable
+     * @var ContainerImageMiddlewareInterface[]
      */
     private iterable $middlewares;
 

src/Core/Container/ContainerMakerInterface.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Dealroadshow\K8S\Framework\Core\Container;
+
+use Dealroadshow\K8S\Data\Collection\VolumeList;
+use Dealroadshow\K8S\Data\Container;
+use Dealroadshow\K8S\Framework\App\AppInterface;
+
+interface ContainerMakerInterface
+{
+    public function make(ContainerInterface $builder, VolumeList $volumes, AppInterface $app): Container;
+}

src/Core/CronJob/AbstractCronJob.php

@@ -36,7 +36,7 @@ public function configureCronJob(CronJob  $cronJob): void
     {
     }
 
-    public static function kind(): string
+    final public static function kind(): string
     {
         return CronJob::KIND;
     }

src/Core/Deployment/AbstractDeployment.php

@@ -26,11 +26,6 @@ public function imagePullSecrets(ImagePullSecretsConfigurator $secrets): void
     {
     }
 
-    public static function kind(): string
-    {
-        return Deployment::KIND;
-    }
-
     public function nodeSelector(StringMap $nodeSelector): void
     {
     }
@@ -66,4 +61,9 @@ public function progressDeadlineSeconds(): ?int
     public function configureDeployment(Deployment $deployment): void
     {
     }
+
+    final public static function kind(): string
+    {
+        return Deployment::KIND;
+    }
 }

src/Core/Ingress/AbstractIngress.php

@@ -18,7 +18,7 @@ public function configureIngress(Ingress $ingress): void
     {
     }
 
-    public static function kind(): string
+    final public static function kind(): string
     {
         return Ingress::KIND;
     }

src/Core/Job/AbstractJob.php

@@ -82,7 +82,7 @@ public function configureJob(Job $job): void
     {
     }
 
-    public static function kind(): string
+    final public static function kind(): string
     {
         return Job::KIND;
     }

src/Core/Pod/PodSpecProcessor.php

@@ -4,17 +4,17 @@
 
 use Dealroadshow\K8S\Data\PodSpec;
 use Dealroadshow\K8S\Framework\App\AppInterface;
-use Dealroadshow\K8S\Framework\Core\Container\ContainerMaker;
+use Dealroadshow\K8S\Framework\Core\Container\ContainerMakerInterface;
 use Dealroadshow\K8S\Framework\Core\Pod\Affinity\AffinityConfigurator;
 use Dealroadshow\K8S\Framework\Core\Pod\Containers\PodContainers;
 use Dealroadshow\K8S\Framework\Core\Pod\ImagePullSecrets\ImagePullSecretsConfigurator;
 use Dealroadshow\K8S\Framework\Core\Pod\Volume\VolumesConfigurator;
 
 class PodSpecProcessor
 {
-    private ContainerMaker $containerMaker;
+    private ContainerMakerInterface $containerMaker;
 
-    public function __construct(ContainerMaker $containerMaker)
+    public function __construct(ContainerMakerInterface $containerMaker)
     {
         $this->containerMaker = $containerMaker;
     }

src/Core/Secret/AbstractSecret.php

@@ -16,7 +16,7 @@ public function stringData(StringMap $stringData): void
     {
     }
 
-    public static function kind(): string
+    final public static function kind(): string
     {
         return Secret::KIND;
     }

src/Core/Service/AbstractService.php

@@ -26,7 +26,7 @@ public function configureService(Service $service): void
     {
     }
 
-    public static function kind(): string
+    final public static function kind(): string
     {
         return Service::KIND;
     }