Merge pull request #1 from dealroadshow/taral-fix-feature

Add second params to `ManifestRegistry` methods
dealroadshow · Oct 9, 2020 · 6c34023 · 6c34023
2 parents f40811c + 5f1f05f
commit 6c34023
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/src/Registry/AppRegistry.php b/src/Registry/AppRegistry.php
@@ -47,6 +47,11 @@ public function has(string $appName): bool
 
     public function get(string $appName): AppInterface
     {
+        if(!$this->has($appName)) {
+            throw new \InvalidArgumentException(
+                sprintf('App "%s" does not exist', $appName)
+            );
+        }
         return $this->apps[$appName];
     }
 }
diff --git a/src/Registry/ManifestRegistry.php b/src/Registry/ManifestRegistry.php
@@ -23,25 +23,27 @@ public function __construct(iterable $manifests)
     /**
      * @param AppInterface $app
      *
+     * @param string|null $className
      * @return iterable|ManifestInterface[]
      */
-    public function byApp(AppInterface $app): iterable
+    public function byApp(AppInterface $app, string $className = null): iterable
     {
         $reflection = new \ReflectionObject($app);
 
-        return $this->byNamespacePrefix($reflection->getNamespaceName());
+        return $this->byNamespacePrefix($reflection->getNamespaceName(), $className);
     }
 
     /**
      * @param string $namespacePrefix
      *
+     * @param string|null $className
      * @return iterable|ManifestInterface[]
      */
-    public function byNamespacePrefix(string $namespacePrefix): iterable
+    public function byNamespacePrefix(string $namespacePrefix, string $className = null): iterable
     {
         foreach ($this->manifests as $manifest) {
             $class = get_class($manifest);
-            if (str_starts_with($class, $namespacePrefix)) {
+            if (str_starts_with($class, $namespacePrefix) && (null === $className || $manifest instanceof $className)) {
                 yield $manifest;
             }
         }

diff --git a/src/Registry/ProjectRegistry.php b/src/Registry/ProjectRegistry.php
@@ -51,6 +51,11 @@ public function has(string $projectName): bool
 
     public function get(string $projectName): ProjectInterface
     {
+        if(!$this->has($projectName)) {
+            throw new \InvalidArgumentException(
+                sprintf('Project "%s" does not exist', $projectName)
+            );
+        }
         return $this->projects[$projectName];
     }
 }