Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable black pre-commit hook #456

Merged
merged 24 commits into from
Nov 11, 2024
Merged

Re-enable black pre-commit hook #456

merged 24 commits into from
Nov 11, 2024

Conversation

copelco
Copy link
Member

@copelco copelco commented Jan 15, 2024 •
edited
Loading

Summary

  • Enable black pre-commit hook
  • Run black on all Python files
  • Add pre-commit to Github actions

@copelco copelco changed the base branch from master to python312-django42 January 15, 2024 01:32
@copelco copelco mentioned this pull request Jan 15, 2024
Merged
@copelco copelco changed the title Re-enable black Re-enable black pre-commit hook Jan 15, 2024
@copelco copelco marked this pull request as ready for review January 15, 2024 14:35
Base automatically changed from python312-django42 to master January 23, 2024 23:14
georgehelman
georgehelman reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@georgehelman georgehelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like black doesn't like the format of migrations automatically generated by Django. How do you feel about excluding the migrations folder from pre-commit?

@robert-w-gries robert-w-gries merged commit 03e577d into master Nov 11, 2024
2 checks passed
@robert-w-gries robert-w-gries deleted the black branch November 11, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehelman georgehelman georgehelman approved these changes

@robert-w-gries robert-w-gries robert-w-gries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Durham Expunction Backlog
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@copelco @robert-w-gries @georgehelman