Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type sys #2

Merged
merged 72 commits into from
Mar 30, 2021
Merged

Type sys #2

merged 72 commits into from
Mar 30, 2021

Conversation

tonyfast
Copy link
Member

  • refactors the code to include most types in the types.py module
  • uses unittest to help organize the tests, we still use hypothesis, but on unittests.

@tonyfast
Copy link
Member Author

rebased on master so we can merge

@tonyfast
Copy link
Member Author

i still need to fix null testing and enum testing

@bollwyvl bollwyvl closed this Mar 13, 2021
@bollwyvl bollwyvl reopened this Mar 13, 2021
@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@5f26287). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   85.65%           
=========================================
  Files             ?        9           
  Lines             ?     1255           
  Branches          ?        0           
=========================================
  Hits              ?     1075           
  Misses            ?      180           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f26287...2f83a69. Read the comment docs.

@bollwyvl
Copy link
Contributor

bollwyvl commented Mar 13, 2021

Nice, tests actually found a thing:

 AttributeError: module 'typing' has no attribute 'ForwardRef'

Looks like the backport actually exposes it as _ForwardRef...

@bollwyvl bollwyvl closed this Mar 23, 2021
@bollwyvl bollwyvl reopened this Mar 23, 2021
@tonyfast
Copy link
Member Author

thanks for the test help @bollwyvl . errythang is green across everything and including pypy!

closing this 💩

@tonyfast tonyfast closed this Mar 30, 2021
@tonyfast tonyfast reopened this Mar 30, 2021
@tonyfast tonyfast merged commit a7b50c3 into master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants