Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegate support for task submission #2

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Add delegate support for task submission #2

merged 2 commits into from
Oct 1, 2023

Conversation

deavmi
Copy link
Owner

@deavmi deavmi commented Oct 1, 2023 •
edited
Loading

Purpose

  • Added support for delegates
  • We now secretly convert everything to a delegate (if a function, otherwise assign directly)

Todo ✍️

  • Unit tests
  • Implementation
    • Move to Value delegate() type
    • Check for isFunction and isDelegate
    • Only convert if isFunction is true

@deavmi
Executor
b8b18f1 
- Added support for delegates
- We now secretly convert everything to a delegate
@deavmi
Executor
5e9a005 
- Only do conversion to a delegate if it is a function, otherwise assign directly (with no conversion)
@deavmi deavmi added the enhancement New feature or request label Oct 1, 2023
@deavmi deavmi self-assigned this Oct 1, 2023
@deavmi deavmi changed the title Executor Add delegate support for task submission Oct 1, 2023
@deavmi
Copy link
Owner Author

deavmi commented Oct 1, 2023

All done, just needs to be merged.

@deavmi
Copy link
Owner Author

deavmi commented Oct 1, 2023

Merging...

@deavmi deavmi merged commit da0fdfc into master Oct 1, 2023
3 checks passed
@deavmi
Copy link
Owner Author

deavmi commented Oct 1, 2023

Merged ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deavmi deavmi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deavmi