DBZ-6998: Align min, max of Histogram/Statistics#91
Merged
nancyxu123 merged 6 commits intodebezium:mainfrom Oct 21, 2024
Merged
DBZ-6998: Align min, max of Histogram/Statistics#91nancyxu123 merged 6 commits intodebezium:mainfrom
nancyxu123 merged 6 commits intodebezium:mainfrom
Conversation
Motivation: Users experienced inconvenience because the statistics-related class was implemented separately. So that we abstracted common methods. Modification: - Fix(Statistics): Add set method Result: User experience will be improved by common methods. Co-authored-by: Bue-von-hon <dkssudvn2@gmail.com> Co-authored-by: chungeun-choi <cucuridas@gmail.com>
|
Welcome as a new contributor to Debezium, @dongwook-chan. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively. |
Contributor
Collaborator
|
@Bue-von-hon No worries. The files in question are located in the main repository. |
Co-authored-by: sean-k1 <uhs2000@naver.com> Co-authored-by: jongwony <lastone9182@gmail.com>
dongwook-chan
force-pushed
the
DBZ-6998
branch
from
2d9b068 to
3e3c598
Compare
Contributor
Author
|
@jpechane |
Bue-von-hon
reviewed
Aug 19, 2024
Co-authored-by: cjho0316 <cjho03160316@gmail.com>
Collaborator
|
@nancyxu123 Hi, can you please take a look? What freedom do we have in playing with metrics? |
Contributor
|
@nancyxu123 PTAL |
Contributor
|
Thanks for the PR! Will take a look this week, thanks! |
Contributor
Overall LGTM. (1) What motivated the need for this PR? (2) Can we add metrics validation into one of the integration tests? For example, any file that ends with IT.java: https://github.com/debezium/debezium-connector-spanner/blob/main/src/test/java/io/debezium/connector/spanner/BasicSanityCheckIT.java |
Contributor
Author
|
@nancyxu123 (1) (2) assertThat(mBeanServer.isRegistered(objectName, "totalLatency")).isEqualTo(true);
assertThat(mBeanServer.isRegistered(objectName, "connectorLatency")).isEqualTo(true);
// and same for the other metrics as well |
Contributor
Sounds good, thanks for the explanation! |
nancyxu123
approved these changes
Oct 7, 2024
jpechane
approved these changes
Oct 8, 2024
Collaborator
jpechane
left a comment
jpechane
left a comment
There was a problem hiding this comment.
@nancyxu123 Feel free to merge when you are satisifed with tests.
Contributor
Author
|
@nancyxu123 |
Contributor
Author
|
@jpechane To resolve the issue, I tried running integration tests.
But the test failed and especially for running Could I get some advice on how to run integration tests? |
Collaborator
|
Hi, I'd recommend to re-build the core repo locally (with clean) and then do the same with Spanner repo. |
Contributor
Author
|
@jpechane To be honest, I'm really not sure what I'm doing wrong here at this point. |
Collaborator
|
Do you use Mac or Linux? |
Contributor
|
@jpechane we use mac |
Collaborator
|
That's probably the explanantion. I really don't know if the simulator image is available for arm too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Users experienced inconvenience because the statistics-related class was implemented separately. So that we abstracted common methods.
Modification:
Result:
User experience will be improved by common methods.