Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Examples for Debezium 2.3 #328

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Naros
Copy link
Member

@Naros Naros commented Aug 4, 2023

No description provided.

Naros added 13 commits August 4, 2023 16:19
Camel 4.0.0-M3 to 4.0.0-RC2
PostgreSQL driver 42.5.1 to 42.6.0
Quarkus 3.0.0.Final to 3.2.3.Final
Jackson 2.13.4 to 2.13.5
Kafka 3.4.0 to 3.5.0
Docker plugin 0.31.0 to 0.40.2
Shade plugin 3.2.1 to 3.5.0
* Java 11 minimum
* Update to Debezium 2.3.2.Final
* Update to Quarkus 3.2.3.Final
* Update to Kafka 3.5.0
* Update to kafka-streams-avro-serde 7.4.0
…deps

* Java 11 minimum
* Update to Debezium 2.3.2.Final
* Update to Quarkus 3.2.3.Final
* Update to Kafka 3.5.0
* Update to Debezium 2.3.2.Final
* Update to Quarkus 3.2.3.Final
* Update to maven-surefire-plugin 3.0.0-M6
@jpechane
Copy link
Contributor

jpechane commented Aug 8, 2023

I wonder if we can come up with a solution to define the version in a single place. It will be probably quite hard for Dockerfiles (we might need to introduce a script that will do it) but java based examples might benefit from a common parent. WDYT?

@Naros
Copy link
Member Author

Naros commented Aug 14, 2023

I think it's partially doable:

  1. Maven could import or be based on some debezium-examples-parent pom.xml
  2. The docker compose files could use extends, but would require docker-compose v3
  3. Docker files could potentially just point to <image>:latest tbh.

All that would then remain would be the README.md and other files that directly reference the versions. Perhaps we might be able to get away with using latest in these contexts too?

I'll look and see if we can do that here in this PR so we can avoid or minimize this effort moving forward.

That said, we do have some examples that need a complete overhaul. For example, some of them simply no longer run without some failure, such as those based on thortail (WildFly Swarm) from 5 years ago. I'd prefer to see whether those can be replaced with Quarkus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants