-
-
Notifications
You must be signed in to change notification settings - Fork 33
Don't trigger any switches if there is only one URL in the list #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This prevents some sites (e.g. HomeAssistant dashboards) from reloading or refreshing repeatedly.
|
First of all, thank you for this awesome project! I used it to set up a HASS dashboard on my Rpi. To do this, I deleted all URLs and just added the one URL to the dashboard. However, I've encountered a rather interesting problem: Every 2 minutes or so (subjective estimate, I didn't time it) the HASS dashboard disconnects and reloads. I could not replicate this on any other system. It took me quite a bit of time until I realized that this is somehow triggered by the switcher.sh script, sending some key strokes to Chromium. This change makes switcher.sh do nothing if there is only one URL in the list. |
|
If there's only 1 URL, then every 100s (10 cycles) it'll try to reload, so your report checks out. I can understand that it may be inconvenient in your case, where the page doesn't need explicit reloading, but for now, this is the intended behavior. We will need to add some advanced control to the dashboard to disable switching and reloading as a long term fix; but given your particular situation, there's a simple fix:
If you update/reinstall the setup, you may have to do this again. I've put this on the roadmap for the next version. Thanks for finding/reporting it. |
|
I would say add an option to each url, ideally a check box, but to make it easy to code you could do something like, if url ends with ?no_refresh that particular URL wont refresh every 10th. This could be handy for things like live camera views, or other pages that self refresh, that if refreshed manually they require a login or something. |
Hi! Can´f find the wayfire.ini file that you are reffering to? |
@dowermyr the repo has been refactored since that comment was posted, and now it's agnostic to Wayland compositor (or desktop managers in general). Now, in order to disable tab switching, you'll need to run: systemctl stop piosk-switcher # to stop temporarily
systemctl disable piosk-switcher # to keep it disabled across reboots
systemctl mask piosk-switcher # to remove the service unit altogether (not recommended) |
This prevents some sites (e.g. HomeAssistant dashboards) from reloading or refreshing repeatedly.