Add option to configure page timeout as part of web ui #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 22, 2025 10:09
debloper
requested changes
May 12, 2025
There was a problem hiding this comment.
Thanks for the PR, but it requires several changes (including multiple instances of s/thomaspcole/debloper/) as well as fundamental difference in the implementation of the configuration.
The implementation should be to the main configuration (through /config and config.json; affecting the main config page), per row of the associated URLs. No need for additional routes.
Also the PR should focus on a specific outcome. For removing cursor etc please send separate PR so they can be properly tracked.
I'm not merging this PR in its current form. If you polish this up I'll take another look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed an easy way to set the page timeout for a non technical user. Added a form element into the web ui to allow for easy change to the timeout value.