Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add more GUI tests #1042

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Add more GUI tests #1042

wants to merge 33 commits into from

Conversation

robintw
Copy link
Collaborator

@robintw robintw commented Sep 28, 2021

🧰 Issue

Fixes #988.

🚀 Overview:

🔗 Link to preview (or screenshot, if relevant)

🤔 Reason:

🔨Work carried out:

  • Tests pass

🖥️ Screenshot

Confirmations

  • I have chosen reviewers for my PR.
  • I have chosen an appropriate label for the PR, adding interactive_review if reviewers will need to see UI
  • I have extended/updated the documentation in \docs folder
  • Any database content changes (Create, Edit, Delete) are recorded in the Log/Changes tables
  • Any database schema changes are implemented via alembic revision transitions
  • I have completed the mandatory sections of this document.
  • I have deleted any unused sections.

📝 Developer Notes:

@IanMayo IanMayo temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 28, 2021 11:12 Inactive
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1042 (99bd48f) into develop (c05a0d9) will increase coverage by 0.28%.
The diff coverage is n/a.

❗ Current head 99bd48f differs from pull request most recent head bd23c86. Consider uploading reports for the commit bd23c86 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1042      +/-   ##
===========================================
+ Coverage    78.89%   79.18%   +0.28%     
===========================================
  Files          104      104              
  Lines        10903    10903              
===========================================
+ Hits          8602     8633      +31     
+ Misses        2301     2270      -31     
Impacted Files Coverage Δ
...epys_admin/maintenance/widgets/custom_text_area.py 63.33% <0.00%> (+1.11%) ⬆️
pepys_admin/maintenance/gui.py 38.88% <0.00%> (+2.69%) ⬆️
pepys_admin/maintenance/widgets/filter_widget.py 53.70% <0.00%> (+6.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e9be4...bd23c86. Read the comment docs.

@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 08:50 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 11:23 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 12:04 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 12:59 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 13:00 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 13:59 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:07 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:13 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:16 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:18 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:22 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:25 Inactive
@robintw robintw had a problem deploying to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:41 Failure
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:47 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 14:52 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 15:04 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 15:09 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 15:14 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 15:22 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 15:27 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 15:33 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv September 30, 2021 15:44 Inactive
@robintw
Copy link
Collaborator Author

robintw commented Oct 1, 2021

As a final update before I leave:

This PR is kinda in a mess right now. There is a useful additional test in tests/gui_tests/test_gui_methods.py that doesn't depend on any of the complex prompt_toolkit stuff. That should probably be merged, as it tests an error-prone part of the GUI implementation.

The tests that rely on interacting with prompt toolkit are broken at the moment. You can see the new tests in test_gui_interactively.py and they are lovely in many ways: written clearly and succinctly, with some nice functions and tooling around them to make them easy to write. Unfortunately they're just very flaky and have particular problems on CI. I've emailed Jonathan (prompt toolkit author) to discuss with him - and will post any response I get here (it should be cc'd to Ian too).

@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv October 8, 2021 21:03 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv October 8, 2021 21:08 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv October 8, 2021 21:11 Inactive
@robintw robintw temporarily deployed to pepys-timeli-add-more-g-sbe8zv October 9, 2021 21:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create more tests for the GUIs
2 participants